Skip to content

Conversation

@BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 9204: feat(import,csv,psv): Add support for importing CSV and PSV files without header rows

    Summary

    • Add --no-header flag to treat the first row in CSV/PSV files as data instead of column names
    • Add --columns option to specify column names when importing files without headers
    • Fix nil pointer panic when importing from stdin with --create-table
      In short, this feature makes Dolt more compatible with MySQL/SQLite workflows and provides users with more flexibility when importing data.

    Problem

    Previously, Dolt always expected the first row of CSV/PSV files to contain column names. This differs from MySQL and SQLite which support importing files where the first row contains data. Users migrating from these systems or working with headerless data files couldn't import them without modifying their files.
    Additionally, when users attempted to import data from stdin using --create-table, they would encounter a nil pointer panic instead of receiving a error message.

    Solution

    The implementation adds:
    1. A new --no-header flag that treats the first row as data instead of column headers
    2. A complementary --columns option to specify column names when headers aren't present
    3. Proper validation to ensure correct flag combinations
    4. Comprehensive error handling for stdin imports with clear error messages
    5. Integration tests for both CSV and PSV files

    Testing

    • Added integration tests for both CSV and PSV files that verify:
    • Importing files with --no-header and --columns options
    • Error cases when required options are missing
    • Original behavior is maintained when not using --no-header
    • Behavior of --columns with and without --no-header
    • Edge cases like stdin imports

go-mysql-server

  • 2981: Unwrap wrapper values used in JSON aggregation functions, and un-skip accidentally-skipped tests for this behavior.
    We were accidentally skipping most of the tests in TestJsonScripts. An error in the test harness meant that skipping one test in this suite would also skip all additional tests.
    A few of the skipped tests were for JSON aggregation functions. The recent "Adaptive Encoding / Wrapper Values" optimization wasn't working properly with these functions because the wrapped values provided to these functions weren't being unwrapped before being inserted into JSON documents. These tests would have caught that issue, but didn't because they were disabled.
    This PR fixes the issue and also re-enables the test.
  • 2979: fix indexing for GROUP BYs and WINDOWs in INSERT and REPLACE statements in TRIGGERS
    Using aggregation and window functions inside a select statement inside an insert source inside a trigger was causing problems. For example, a trigger defined like so:
    create trigger trig before insert on t1
    for each row
    begin
    insert into t2
    select
    max(id),
    first_value(id) over (partition by id order by id),
    ...
    from
    t3;
    end;
    
    The issue involved the Projections over the Group Bys. The scope for the group bys already contained the trigger's columns and are indexed uniquely, so we shouldn't include the trigger/parent scope.

Closed Issues

  • 9222: JSON_OBJECT error on longtext columns - "unsupported type: *val.TextStorage"
  • 7831: Allow importing CSVs without column names.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels May 16, 2025
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 16, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 16, 2025 23:22
@BrewTestBot BrewTestBot added this pull request to the merge queue May 16, 2025
Merged via the queue into master with commit 3b6248d May 16, 2025
17 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.53.5 branch May 16, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants